Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mgmt, appservice migrate test proxy #35994

Merged
merged 3 commits into from
Jul 21, 2023
Merged

mgmt, appservice migrate test proxy #35994

merged 3 commits into from
Jul 21, 2023

Conversation

weidongxu-microsoft
Copy link
Member

@weidongxu-microsoft weidongxu-microsoft commented Jul 20, 2023 •
edited
Loading 

>\CredScanClient\lib\net6.0\CredentialScanner.exe -I .assets -O credscan
Start credential scanner
Initializing...
Initialization completed.
Start file scanning...
NumberOfAsset : 65
NumberOfAssetScanned : 44
NumberOfAssetBytes : 36,750,557
NumberOfAssetBytesScanned : 36,191,752
NumberOfScanResult: 0
NumberOfRankedResult : 0
NumberOfCredentialRecord: 0
NumberOfSuppressedRecord: 0
NumberOfScanError: 0

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@weidongxu-microsoft weidongxu-microsoft added the test-proxy Anything relating to test-proxy requests or issues. label Jul 20, 2023
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@weidongxu-microsoft weidongxu-microsoft marked this pull request as ready for review July 20, 2023 05:22
samvaity
samvaity approved these changes Jul 20, 2023
View reviewed changes
Copy link
Member

@samvaity samvaity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🎉

@samvaity samvaity mentioned this pull request Jul 20, 2023
Closed
@weidongxu-microsoft weidongxu-microsoft merged commit 24f6042 into Azure:main Jul 21, 2023
@weidongxu-microsoft weidongxu-microsoft deleted the mgmt_appservice-test-proxy branch July 21, 2023 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samvaity samvaity samvaity approved these changes

@haolingdong-msft haolingdong-msft Awaiting requested review from haolingdong-msft haolingdong-msft is a code owner

@XiaofeiCao XiaofeiCao Awaiting requested review from XiaofeiCao XiaofeiCao is a code owner

@ArthurMa1978 ArthurMa1978 Awaiting requested review from ArthurMa1978 ArthurMa1978 is a code owner

Assignees
No one assigned
Labels
test-proxy Anything relating to test-proxy requests or issues.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@weidongxu-microsoft @azure-sdk @samvaity